lib/tasks/validateCreateTaskBody.ts (1)

73-102: Split request-level validation into its own file to preserve SRP and naming consistency.

validateCreateTaskRequest introduces a second exported validator in a ...Body.ts module and is >20 lines while handling multiple responsibilities (JSON parse, body validate, auth validate, account override). Please move it to a dedicated file (for example, validateCreateTaskRequest.ts) and keep validateCreateTaskBody.ts focused on schema/body validation.

As per coding guidelines: lib/**/*.ts: "Apply Single Responsibility Principle (SRP): one exported function per file; each file should do one thing well", **/*.{js,ts,tsx,jsx}: "each file must export ONE primary function, and the file name must match that function", and **/*.{js,ts,tsx,jsx,py,java,cs,go,rb,php}: "Flag functions longer than 20 lines".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/tasks/validateCreateTaskBody.ts` around lines 73 - 102, The
validateCreateTaskRequest function in validateCreateTaskBody.ts mixes JSON
parsing, body validation, auth check and account override and must be moved to
its own file; create a new file named e.g. validateCreateTaskRequest.ts
exporting the single function validateCreateTaskRequest, have it call
validateCreateTaskBody(body) for schema validation and
validateAuthContext(request, { accountId: validatedBody.account_id }) for auth,
reuse getCorsHeaders for the JSON parse error response, and return the merged
object with account_id: auth.accountId; remove the validateCreateTaskRequest
export from validateCreateTaskBody.ts so that file only exports
validateCreateTaskBody.

lib/tasks/createTaskHandler.ts (1)

21-53: Consider trimming createTaskHandler to keep it under the 20-line guideline and more focused.

The handler currently mixes validation orchestration, persistence call, and response shaping. Extracting response builders (success/error) would keep this function tighter and easier to maintain.

As per coding guidelines: **/*.{js,ts,tsx,jsx,py,java,cs,go,rb,php}: "Flag functions longer than 20 lines" and lib/**/*.ts: "Single responsibility per function".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/tasks/createTaskHandler.ts` around lines 21 - 53, createTaskHandler is
doing validation, persistence and response shaping in one function; extract the
success and error response builders into small helpers (e.g.,
buildCreateTaskSuccessResponse and buildCreateTaskErrorResponse) and move the
NextResponse.json + getCorsHeaders logic into those helpers so createTaskHandler
only orchestrates validateCreateTaskRequest and createTask and returns the
helper results; keep existing behavior (return validated NextResponse early,
call createTask with validatedBody, log error in the catch and pass
error.message into the error builder) and reference createTaskHandler,
validateCreateTaskRequest, createTask, getCorsHeaders when locating where to
extract helpers.

lib/tasks/validateCreateTaskBody.ts (1)

46-87: Function exceeds the 20-line limit.

validateCreateTaskRequest spans ~42 lines and consolidates three distinct responsibilities: JSON parsing, Zod schema validation, and auth context validation with account_id override. While bundling these for request-level validation is pragmatic, consider extracting the JSON parsing and schema validation into a helper to keep this function focused on orchestration and under the line limit.

♻️ Suggested refactor to reduce function length

Extract JSON parsing and schema validation into a separate helper (e.g., parseAndValidateBody):

+async function parseAndValidateBody(
+  request: NextRequest,
+): Promise<NextResponse | z.infer<typeof createTaskBodySchema>> {
+  let body: unknown;
+  try {
+    body = await request.json();
+  } catch {
+    return NextResponse.json(
+      { status: "error", error: "Invalid JSON body" },
+      { status: 400, headers: getCorsHeaders() },
+    );
+  }
+
+  const validationResult = createTaskBodySchema.safeParse(body);
+  if (!validationResult.success) {
+    const firstError = validationResult.error.issues[0];
+    return NextResponse.json(
+      {
+        status: "error",
+        missing_fields: firstError.path,
+        error: firstError.message,
+      },
+      { status: 400, headers: getCorsHeaders() },
+    );
+  }
+  return validationResult.data;
+}
+
 export async function validateCreateTaskRequest(
   request: NextRequest,
 ): Promise<NextResponse | CreateTaskBody> {
-  let body: unknown;
-  try {
-    body = await request.json();
-  } catch {
-    return NextResponse.json(
-      { status: "error", error: "Invalid JSON body" },
-      { status: 400, headers: getCorsHeaders() },
-    );
-  }
-
-  const validationResult = createTaskBodySchema.safeParse(body);
-  if (!validationResult.success) {
-    const firstError = validationResult.error.issues[0];
-    return NextResponse.json(
-      {
-        status: "error",
-        missing_fields: firstError.path,
-        error: firstError.message,
-      },
-      {
-        status: 400,
-        headers: getCorsHeaders(),
-      },
-    );
-  }
-
-  const validatedBody = validationResult.data;
+  const validatedBody = await parseAndValidateBody(request);
+  if (validatedBody instanceof NextResponse) {
+    return validatedBody;
+  }

   const auth = await validateAuthContext(request, {
     accountId: validatedBody.account_id,
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/tasks/validateCreateTaskBody.ts` around lines 46 - 87, The
validateCreateTaskRequest function is too long and mixes JSON parsing, Zod
validation, and auth logic; extract the JSON parsing and schema validation into
a new helper (e.g., parseAndValidateBody) that performs request.json() with the
existing error response (using NextResponse and getCorsHeaders) and runs
createTaskBodySchema.safeParse returning either a validated CreateTaskBody or a
NextResponse error; then simplify validateCreateTaskRequest to call
parseAndValidateBody, short-circuit if it returns a NextResponse, and only run
validateAuthContext and the account_id override (using validateAuthContext and
returning the merged body) so the main function stays under 20 lines.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes